Er I mean... (was: RE: [PATCH] next_dialog micropatch (3)(was: RE: [setup PATCH] next_dialog micropatch (2)))
Max Bowsher
maxb@ukf.net
Tue Jul 29 09:50:00 GMT 2003
Robert Collins wrote:
> On Tue, 2003-07-29 at 13:47, Gary R. Van Sickle wrote:
>> ...this straightforward patch:
>>
>> 2003-07-28 Gary R. Van Sickle <g.r.vansickle@worldnet.att.net>
>> * dialog.h (do_fromcwd): Change function declaration.
>> * fromcwd.cc (do_fromcwd): Change return type to bool. Eliminate
>> use of next_dialog, return true or false instead.
>> * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
>> value instead of next_dialog.
>
> Approved, subject to one caveat:
> instead of
> bool found_ini;
> found_ini = do_fromcwd ()..
> if (found_ini)
>
> please use
> if (do_fromcwd(...)) {
>
> unneeded temporary variables are annoying.
Committed, with the above change.
Max.
More information about the Cygwin-apps
mailing list