Proposal: stunnel

[Max Bowsher]

Marcel Telka wrote:
> On Wed, Jun 25, 2003 at 07:19:14PM +0100, Max Bowsher wrote:
>> Marcel Telka wrote:
>>> I've created stunnel packages for cygwin:
...
>> A few comments:
...
> Thank you for your comments.
>
> I've updated proposed stunnel packages:
> http://telka.sk/cygwin/stunnel/setup.hint
> http://telka.sk/cygwin/stunnel/stunnel-4.04-2-src.tar.bz2
> http://telka.sk/cygwin/stunnel/stunnel-4.04-2.tar.bz2

Thanks.

Sorry I didn't spot this before, but:

  if [ ! -d ${instdir}${prefix}/var/run/stunnel ]; then \
    mkdir -p ${instdir}${prefix}/var/run/stunnel ; \
  fi && \

is incorrect. (Remove ${prefix}).

Also, there are some bugs in stunnel.conf-sample.in and stunnel.init.in -
they are using @prefix@/foo where they should be using @localstatedir@ or
@sysconfdir@. This causes the paths to be incorrect. (You may wish to submit
these changes upstream.)


Once these are fixed, I believe the packaging is fully correct, though I or
someone else still needs to do a functionality review. I will probably get
to this in a day or two, unless someone beats me to it.


Max.