[PATCH] Add logging of move-on-reboot scheduling

Igor Pechtchanski pechtcha@cs.nyu.edu
Thu Mar 13 22:26:00 GMT 2003


Hi,

Currently the replace-on-reboot files are only logged if unable to
schedule them.  I've run into this problem and wanted to know what files
will be replaced, and this information is apparently not in the log.  The
attached patch adds it.

It also does this (untested) for Win9x.  In fact, is there a particular
reason rebootneeded is not set to true on Win9x?  Rob?
	Igor
==============================================================================
ChangeLog:
2003-03-13  Igor Pechtchanski <pechtcha@cs.nyu.edu>

	* install.cc (install_one_source): Add logging for
	successful replace-on-reboot scheduling.  Also set
	rebootneeded on Win9x.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune
-------------- next part --------------
Index: install.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/install.cc,v
retrieving revision 2.57
diff -u -p -r2.57 install.cc
--- install.cc	12 Mar 2003 22:15:25 -0000	2.57
+++ install.cc	13 Mar 2003 22:14:07 -0000
@@ -291,7 +291,15 @@ install_one_source (packagemeta & pkgm, 
 				   GetLastError ());
 			      ++errors;
 			    }
-
+			  else
+			    {
+			      log (LOG_TIMESTAMP,
+				  "Scheduled reboot replacement of file %s with %s",
+				  cygpath (String ("/") + fn).cstr_oneuse(),
+				  cygpath (String ("/") + fn +
+					   ".new").cstr_oneuse());
+			      rebootneeded = true;
+			    }
 			}
 		    }
 		      break;
@@ -315,7 +323,13 @@ install_one_source (packagemeta & pkgm, 
 			  ++errors;
 			}
 		      else
-			rebootneeded = true;
+			{
+			  log (LOG_TIMESTAMP,
+			       "Scheduled reboot replacement of file %s with %s",
+			       cygpath (String ("/") + fn).cstr_oneuse(),
+			       cygpath (String ("/") + fn + ".new").cstr_oneuse());
+			  rebootneeded = true;
+			}
 		      break;
 		    }
 		}


More information about the Cygwin-apps mailing list