[PATCH] Add logging of move-on-reboot scheduling

Robert Collins rbcollins@cygwin.com
Thu Mar 13 23:14:00 GMT 2003


On Fri, 2003-03-14 at 10:07, Igor Pechtchanski wrote:
> On 14 Mar 2003, Robert Collins wrote:

> > Please Extract Method on the duplicate code here.
> > Cheers,
> > Rob
> 
> Umm, shouldn't we do this as two separate steps?  There's duplicate code
> galore all over that function...  Or do you want it all in one patch?

I was only worried about the code that is being touched by the patch. I
think it's sufficiently small that a single patch will be ok.

Just describe in the patch log the two steps.

Cheers,
Rob

-- 
GPG key available at: <http://users.bigpond.net.au/robertc/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20030313/db9ec655/attachment.sig>


More information about the Cygwin-apps mailing list