generic build doubts, part 2

[Igor Pechtchanski]

On Tue, 24 Feb 2004, Lapo Luchini wrote:

> Packaging libungif I had the need to slightly change configure, but had
> not the will to autoreconf it all, unnecessarily creating a huge patch
> where only a single line change was needed.
> At this very time I discovered patch doesn't by default sets times, and
> uses current time unless -Z is used.
> This of course triggered the "missing" upon make invokation, which is
> not wanted, if the user doesn't have the autotools, and in this specific
> case is just lost time anyway.
>
> So I figured: why patch has this strange default?
> Shouldn't we use -Z by default?
> Would that have "bad effects" apart from the good effect that I wouldn't
> have turned crazy understanding why file date was current even if I
> "patched the patch" to have the correct time?
>
> Lapo

Lapo,

Cool.  I had the exact same problem with pdksh.  I solved it by adding

@@ -129,6 +129,7 @@ prep() {
 }
 conf() {
   (cd ${objdir} && \
+  touch ${srcdir}/stamp-h.in ${srcdir}/config.h.in ${srcdir}/configure && \
   CFLAGS="${MY_CFLAGS}" LDFLAGS="${MY_LDFLAGS}" \
   ${srcdir}/configure \
   --srcdir=${srcdir} --prefix=${prefix} \

to the build script, but your way (using "patch -Z") is better.  Please go
ahead and submit a patch to the build script, and I'll apply it.  AFAICS,
there should be no adverse effects.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton