[Review] sgrep-1.92.1-1 - No good to go yet

Dr. Volker Zell Dr.Volker.Zell@oracle.com
Tue Jan 27 11:21:00 GMT 2004

>>>>> "Jari" == Jari Aalto writes:

    Jari> Based on comments for sgrep I've repackaged the project. Please review.

    Jari>   http://tierra.dyndns.org:81/cygwin/sgrep/setup.hint 
    Jari>   http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1-src.tar.bz2 
    Jari>   http://tierra.dyndns.org:81/cygwin/sgrep/sgrep-1.92.1-1.tar.bz2

Hi Jari

 o From the cygwin specific README:

Build instructions:
  unpack sgrep-1.92.1-1-src.tar.bz2
    if you use setup to install this src package, it will be
         unpacked under /usr/src automatically
  cd /usr/src
  ./cygbuild*.sh all

But the build script is sgrep-1.92.1-1.sh

 o The packaging list claims that the sample sgreprc file is located under


but it actually is under


Is this the right location anyway ? and shouldn't it get copied to
/usr/share in a postinstall script ?

 o The man page says that sgreprc would be searched under /usr/lib/sgreprc

Can we patch this to /usr/share

 o There is still an error in the build script:

When I run bash ./sgrep*sh -v all I get

-- cygbuild.sh 2004-01-26 1.230 http://cygbuild.sourceforge.net/
-- Wait, examining environment and preparing variables
./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected
./sgrep-1.92.1-1.sh: line 505: [: -eq: unary operator expected
-- Extracting /tmp/sgrep/sgrep-1.92.1.tar.gz

Other than that, it seems to work fine.


More information about the Cygwin-apps mailing list