[Review - no go] boxes-2000.0401 - Draw character boxes
Fri Jan 30 17:44:00 GMT 2004
On Thu, 29 Jan 2004, Igor Pechtchanski wrote:
> On Thu, 29 Jan 2004, Jari Aalto+mail.linux wrote:
> > See http://boxes.thomasjensen.com/
> > Packages available for review:
> > http://tierra.dyndns.org:81/cygwin/boxes/boxes-2000.0401-1-src.tar.bz2
> > http://tierra.dyndns.org:81/cygwin/boxes/boxes-2000.0401-1.tar.bz2
> > http://tierra.dyndns.org:81/cygwin/boxes/setup.hint
> > To download:
> > wget -q -O - http://tierra.dyndns.org:81/cygwin/boxes/get.sh | sh
> This has my vote. If noone beats me to it, I'll try to do a review
First off, apologies for the incorrect Reply-To: in the previous message.
Now, here's the review:
1) The README reports the package version as 1.0.1. If you wanted to use
a CVS-based version instead, the convention is to not put a "." between
the year and the date (e.g., ash-20031007-1). Incidentally,
README.Win32.txt reports the version as 20000318 (not 20000401).
--- BINARY PACKAGE ISSUES ---
2) Running the boxes.exe executable results in a "boxes: Can't find config
file." message. Looks like it expects the config file in
3) The Cygwin-specific readme indicates 1.3.22 as the minimum Cygwin
version. Is that a typo?
4) The man page has a --GLOBALCONF-- string for the system-wide config
file name -- should that have been replaced by something like
--- SOURCE PACKAGE ISSUES ---
5) The source package directory is named "boxes-SNAP-20000401". The patch
doesn't apply properly because of that. The script handles it somewhat,
but will break when run from /usr/src if there are any other sources
6) The patch removes the generated files. Is there any reason for that?
Can't they just be re-generated? That makes the patch quite large (154k).
IMO, the versioning (#1) and the config file (#2 & #4) issues above are
the most important hold-ups. The directory naming issue (#5) is also
important, as the script will break if there's more than one directory.
|\ _,,,---,,_ firstname.lastname@example.org
ZZZzz /,`.-'`' -. ;-;;,_ email@example.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster." -- Patrick Naughton
More information about the Cygwin-apps