Generic build script instructions

Igor Pechtchanski pechtcha@cs.nyu.edu
Fri Jun 18 13:04:00 GMT 2004


Bas,

Oh, and one more comment:

On Fri, 18 Jun 2004, Bas van Gompel wrote:

> [snip]
> @@ -339,6 +344,7 @@ case $1 in
>                 strip && pkg && spkg && finish ; \
>                 STATUS=$? ;;
>    *) echo "Error: bad arguments" ; exit 1 ;;
> -esac
> -exit ${STATUS}
> -
> +  esac
> +  ( exit ${STATUS} ) || exit ${STATUS}
     ^^^^^^^^^^^^^^^^^^
> +  shift
> +done

Do we really need a subshell here?  Isn't an "if" test enough (and more
efficient)?
	Igor
P.S. I'm wondering whether I should ask for two separate patches, as they
are independent and it's a bit hard to see the addition of "ispatch()"
with the indentation adjustment...
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton



More information about the Cygwin-apps mailing list