[PATCH] for generic-build-script

Igor Pechtchanski pechtcha@cs.nyu.edu
Thu May 20 13:08:00 GMT 2004


On Thu, 20 May 2004, Gerrit P. Haase wrote:

> Hallo Igor,
>
> Am Mittwoch, 19. Mai 2004 um 19:47 schriebst du:
>
> > On Wed, 19 May 2004, Christopher Faylor wrote:
>
> >> On Wed, May 19, 2004 at 03:52:04PM +0200, Gerrit P. Haase wrote:
> >> >Hallo cygwin-apps,
> >> >
> >> >--- generic-build-script~       2004-05-19 15:49:55.827961600 +0200
> >> >+++ generic-build-script        2004-05-19 15:49:41.196923200 +0200
> >> >@@ -180,7 +180,7 @@
> >> >     fi ;\
> >> >   done &&\
> >> >   if [ -d ${instdir}${prefix}/share/info ] ; then \
> >> >-    find ${instdir}${prefix}/share/info -name "*.info" | xargs gzip -q ; \
> >> >+    find ${instdir}${prefix}/share/info -name "*" | xargs gzip -q ; \
> >>
> >> -name "*" is a no-op.  You can just remove it.
>
> > Yep.  I think what was intended here was "-type f".
>
> Yes, of course.

Actually, given your explanation in the previous message, why wouldn't
'-name "*.info*"' suffice?  Also, come to think of it, '-name "*"' is
*not* a no-op, it'll filter out hidden files (".*").

> [...]
>
> > Gerrit, how about a resubmit, with or without the quoting, but with a
> > ChangeLog?
>
> Lets wait for Yaakov, I suggested to clean it up like I do for the GCC
> package.  He already submitted an update to my patch.
>
> --- g-b-s.orig    2004-05-16 11:01:13.760731200 +0200
> +++ g-b-s 2004-05-20 11:08:26.311102400 +0200
> @@ -181,12 +181,10 @@
>      fi ;\
>    done &&\
>    if [ -d ${instdir}${prefix}/share/info ] ; then \
> -    find ${instdir}${prefix}/share/info -name "*" | xargs gzip -q ; \
> +    ( cd ${instdir}${prefix}/share/info ; rm -f dir ; gzip -fq9 * ) ;\

This will omit hidden files (not a problem, I think, just a note).

>    fi && \
>    if [ -d ${instdir}${prefix}/share/man ] ; then \
> -    find ${instdir}${prefix}/share/man -name "*.1" -o -name "*.3" -o \
> -      -name "*.3x" -o -name "*.3pm" -o -name "*.5" -o -name "*.6" -o \
> -      -name "*.7" -o -name "*.8" | xargs gzip -q ; \
> +    ( cd ${instdir}${prefix}/share/man && gzip -fq9 */* ) ;\

Are you sure gzip will handle subdirectories correctly?  I have to look at
gzip's manpage and info pages carefully...

>    fi && \
>    templist="" && \
>    for f in ${install_docs} ; do \
>
> Gerrit

One more thing: shouldn't the separators in the commands be '&&' instead
of ';'?
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha@cs.nyu.edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor@watson.ibm.com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski, Ph.D.
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"I have since come to realize that being between your mentor and his route
to the bathroom is a major career booster."  -- Patrick Naughton



More information about the Cygwin-apps mailing list