[g-b-s Patch: next try] Write and save logfiles for configure/make/check/install
Igor Pechtchanski
pechtcha@cs.nyu.edu
Fri Oct 14 14:20:00 GMT 2005
On Mon, 10 Oct 2005, Dr. Volker Zell wrote:
> >>>>> Igor Pechtchanski writes:
>
> > On Mon, 10 Oct 2005, Dr. Volker Zell wrote:
> >> @@ -340,6 +349,7 @@
> >> cp $0.sig ${srcinstdir}/ ; \
> >> fi && \
> >> cd ${srcinstdir} && \
> >> + tar cvjf ${log_pkg_name} *.LOG && rm *.LOG && \
> >> tar cvjf ${src_pkg} * )
> >> }
> >> finish() {
>
> > One small issue here: would it make sense to list the files explicitly for
> > both "tar" and "rm", instead of just using *.LOG? Suppose the variable
> > values get changed?
>
> > This would, of course, require some rethinking of the variable values
> > (i.e., the explicit path), or we could just change it to
>
> > + tar cvjf ${log_pkg_name} ${configurelogfile%%${srcinstdir}/} \
> > + ${makelogfile%%${srcinstdir}/} ${checklogfile%%${srcinstdir}/} \
> > + ${installlogfile%%${srcinstdir}/} && \
> > + rm *.LOG ${configurelogfile%%${srcinstdir}/} \
> > + ${makelogfile%%${srcinstdir}/} ${checklogfile%%${srcinstdir}/} \
> > + ${installlogfile%%${srcinstdir}/} && \
>
> > (using bash-isms).
>
> > Comments?
>
> No problem, but this time it's your turn :-) This takes way to long.
> Please check in if nobody else objects.
One thing I didn't notice earlier about either this patch or your original
one is that you removed the second "cd $(topdir)" from prep(). I know it
looks superfluous, but it's there for a reason (so that unpack() can
change directory with impunity -- yes, this happened to me before).
Applied, with that one change removed. Thanks for the patch. I'll
address the above *.LOG issue shortly.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
More information about the Cygwin-apps
mailing list