[g-b-s Patch: next try] Write and save logfiles for configure/make/check/install
Igor Pechtchanski
pechtcha@cs.nyu.edu
Tue Oct 18 05:11:00 GMT 2005
On Mon, 17 Oct 2005, Eric Blake wrote:
> According to Igor Pechtchanski on 10/16/2005 4:35 PM:
>
> > Ah, thanks, I wasn't aware that setup.html recommended running spkg right
> > after mkdirs.
> >
> > This will still create an (empty) ${log_pkg_name} tarball, which will get
> > included in the source package (making it a bit misleading).
> >
> > I've made the log tarball creation conditional on the existence of the log
> > files. Thanks for bringing this matter up.
>
> Still doesn't work. Your version only checks the existance of
> configurelogname, but it is possible to have that and not all three of
> {make,check,install}logname.
Yes, a very valid point. I was lazy.
> For example, the newly uploaded
> coreutils-5.90-3 does not have a check log (only configure, make, and
> install). Part of the problem here is that 'g-b-s all' does not, by
> default, run 'g-b-s check', although I'm not sure if we should change that.
Also a valid point.
> Also, I recommend that make check be passed -k, so that the entire test
> suite is run, rather than giving up on the first failure; after all, some
> failures are bugs in the test suite (meaning non-portable tests that
> cannot work in cygwin, but which haven't been patched to SKIP yet).
>
> 2005-10-17 Eric Blake <ebb9@byu.net>
>
> * templates/generic-build-script (check): Run all tests.
> (spkg): Don't fail if one of the four logs is missing.
Thanks, applied. FWIW, I've also made the g-b-s check for any one of the
log files, and only create the tarball if at least one exists.
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ pechtcha@cs.nyu.edu
ZZZzz /,`.-'`' -. ;-;;,_ igor@watson.ibm.com
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. /DA
More information about the Cygwin-apps
mailing list