[Patch] setup source page should use command-line option over last selected

Christopher Faylor cgf-no-personal-reply-please@cygwin.com
Thu Jan 19 18:42:00 GMT 2006

On Thu, Jan 19, 2006 at 10:44:56AM -0000, Dave Korn wrote:
>Thrall, Bryan wrote:
>> Thrall, Bryan wrote on Thursday, January 12, 2006 1:17 PM:
>>> Setup.exe currently (based on CVS HEAD) uses the last selected option
>>> from the Source page instead of the command line option (if it is
>>> present). For example, if the user selected "Download without
>>> installing" the last time they ran setup, then that will be selected
>>> the next time setup runs regardless of the command line.
>>> To reproduce:
>>> 1) Run 'setup.exe' and on the "Choose Download Source" page, select
>>> (for example) "Download without installing". Click next, then cancel.
>>> 2) Run 'setup.exe -L' and go to the "Choose Download Source" page.
>>> "Install from local directory" should be selected, but "Download without
>>> installing" still is. 
>>> The attached patch should fix this.
>> *ping*
>> Am I wrong in thinking that the command line options should override the
>> last user-choice?
>> Thanks,
> *pong*
> Of course you aren't wrong in thinking that the command line options should
>override the last user-choice!
>  You're welcome!

So, since there is now this unbelievable consensus and good will could someone
check in the patch?


More information about the Cygwin-apps mailing list