[PATCH] setup: fix abnormal exit test for postinstall scripts

Igor Peshansky pechtcha@cs.nyu.edu
Mon Jan 23 17:11:00 GMT 2006


Hi,

Just noticed that the postinstall mechanism in setup inverts the test for
abnormal exit.  The attached one-liner patch fixes that.  ChangeLog below.
	Igor
==============================================================================
2006-01-23  Igor Peshansky  <pechtcha@cs.nyu.edu>

	* script.cc (Script::run): Fix inverted test for abnormal exit.

-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha@cs.nyu.edu | igor@watson.ibm.com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
-------------- next part --------------
Index: script.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/script.cc,v
retrieving revision 2.21
diff -u -p -r2.21 script.cc
--- script.cc	14 Oct 2005 04:00:50 -0000	2.21
+++ script.cc	23 Jan 2006 17:07:02 -0000
@@ -243,7 +243,7 @@ Script::run() const
   if (to_log && !file_out.isEmpty ())
     log(LOG_BABBLE) << file_out << endLog;
 
-  if (!retval)
+  if (retval)
     log(LOG_PLAIN) << "abnormal exit: exit code=" << retval << endLog;;
 
   /* if file exists then delete it otherwise just ignore no file error */


More information about the Cygwin-apps mailing list