[PATCH] setup: replace radiobuttons on chooser
Tue Mar 14 16:20:00 GMT 2006
On 14 March 2006 16:03, Max Bowsher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> Dave Korn wrote:
>> Hi all, here's my contribution to the current setup patchfrenzy!
>> The radiobuttons for Prev, Keep, Curr, Exp at the top of the package
>> chooser should never have been radiobuttons. They don't select a
>> persistent mode, they perform an instantaneous action. Action buttons
>> should be pushbuttons. Hence this patch changes them to pushbuttons.
> They seem to have BOTH an instantaneous AND a persistent influence,
> actually - so I'd prefer to keep using controls which display the
> current state.
Huh? AYS? As far as I can see, there is code in
ChooserPage::OnMessageCmd that responds to clicking any given one by calling
keepClicked() or changeTrust(xxx), and there's nothing else anywhere else that
could query or in any way respond to the state of the buttons or that tests
which one is checked or anything. Why do you say they have a persistent
influence? I'm /very/ convinced that they change the state of the selection
when clicked and it's a one-shot, what bit of the code are you looking at that
>> Also, the view button with the cycling every time you click it thing?
>> Eww! :-P
>> So I made it a combo box. Now you can switch straight from one view to
>> another without stepping through the ones you didn't want to see first. I
>> think that's more windows-UI-y-ish, IYSWIM.
> Thankyou thankyou thankyou!
> I don't suppose you feel like separating these two elements into
> individual patches?
Of course, but I think that you're mistaken about the persistence and so
will wait at least one exchange of mails further in case you say "Oh, maybe
not after all" and I can save the trouble and go and apply them both at once.
BTW, this patch would interact/conflict with Bas/Buzz's one to remember the
last view setting:
which is still pending. I could up-port the patch to integrate with the new
framework if it's still desirable? (Seems to me like it's a good patch in
concept, but I'm not familiar enough with the user prefs stuff to give it any
more than a cursory review).
Can't think of a witty .sigline today....
More information about the Cygwin-apps