[ITA / RFU] wtf-.0.0.4-7

[Yaakov (Cygwin/X)]

On 08/07/2009 18:29, Chris Sutcliffe wrote:
> Since I've switched to cygport from Igor's build script, I'd
> appreciate if someone could give the packaging a once over.

If I may, a few points:

1) In SRC_URI, using mirror://sourceforge/ instead of 
http://sourceforge.net/ allows you to use a preferred mirror to 
download.  (See /usr/share/cygport/mirrors for other sites which use the 
mirror:// syntax.)

2) Your .cygport builds in ${S}, which you shouldn't do because it 
spoils the patch; you should build in ${B} instead, and since wtf 
doesn't use a VPATH-supporting buildsystem, use lndirs() to get 
everything in ${B}.

3) Your src_install is completely unnecessary; the default suffices. 
BTW, in general you should use e.g. "dodir /usr/bin" instead of "mkdir 
-p ${D}/usr/bin", but the makefiles do create the directories as they 
should.

Revised .cygport attached.


Yaakov
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: wtf-0.0.4-7.cygport
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20090709/3924602a/attachment.ksh>