[PATCH] Another setup.exe infinite loop in unattended mode.

Dave Korn dave.korn.cygwin@googlemail.com
Sun Nov 22 03:36:00 GMT 2009


    Hi,

  I found another one.  In unattended mode, if the setup.ini download or
signature verification fails, we can loop forever trying again, because
there's no user to select a different mirror.  A parallel problem exists if we
try and install from a local package dir with no or a corrupt setup.ini file.
 The first case is worth retrying a few times, because it might just be a
network glitch; the second not.

  (Note that this all only kicks in if *all* the selected mirrors / local
package dir setup.ini files are invalid.)

	* threebar.cc (ThreeBarProgressPage::OnMessageApp): Don't loop forever
	retrying ini file download/parse if it errors in unattended mode.

  Ok?

    cheers,
      DaveK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ya-unattended-infloop.diff
Type: text/x-c
Size: 1499 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20091122/04437d3d/attachment.bin>


More information about the Cygwin-apps mailing list