[PATCH] Stop automatic dependency selection on setup.exe chooser screen

Andy Koppe andy.koppe@gmail.com
Fri Aug 6 18:21:00 GMT 2010

On 6 August 2010 18:09, Andy Koppe wrote:
> On 6 August 2010 17:00, Corinna Vinschen wrote:
>>> On Fri, Aug 06, 2010 at 01:25:54PM +0100, Andy Koppe wrote:
>>> >The dependency resolver page only adds direct
>>> >dependencies of packages that have been selected, not indirect ones,
>>> >so you end up with missing DLLs. (They do get added before the package
>>> >selection screen if you run setup.exe again.)
>> I'm looking into it, but it's tricky for people not quite up to speed
>> with STL.  Basically the elements in unmap also have to be tested for
>> unsatisfied dependencies.  One problem is that unmet is a map, so, when
>> adding elements to unmet, there has to be some marker which allows to
>> recognize elements which already have been tested for dependencies,
>> otherwise it will be rather slow.
> I'm hoping this won't need to be implemented from scratch, given
> indirect dependencies already do work elsewhere.

Misplaced hope, because packageversion::set_requirements, which is
used on the chooser page, selects packages right away, whereas on the
PreReq page they're first collected into a list of packages (and their
requirees) to display to the user.

I'll have a go at PrereqChecker::isMet() then.


More information about the Cygwin-apps mailing list