[PATCH] Stop automatic dependency selection on setup.exe chooser screen

Corinna Vinschen corinna-cygwin@cygwin.com
Fri Aug 6 21:06:00 GMT 2010

On Aug  6 21:52, Andy Koppe wrote:
> On 6 August 2010 21:36, Christopher Faylor  wrote:
> > On Fri, Aug 06, 2010 at 10:26:02PM +0200, Corinna Vinschen wrote:
> >>Looks still good, doesn't it?
> >
> > Yep.  Andy do you agree?
> I'm still working on a patch that tries to address this without a
> second dependency checking loop, by putting all desired packages into
> a todo list at the start, and then adding to it as we go through it
> and find missing dependencies.
> But since Corinna got there first ... . Doesn't the first loop need a
> (*n).first->prereq_checked (true) as well though?

No.  The first loop only adds packages to the so far empty unmet map.
The second run has to test all packages in the unmet map.

Only in that second run we set the flag to make sure that every package
is only tested once for its direct dependencies.  In every run of the
loop, only the packages which have been added in the previous run are


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

More information about the Cygwin-apps mailing list