[PATCH] Stop automatic dependency selection on setup.exe chooser screen

[Corinna Vinschen]

On Aug  6 17:34, Charles Wilson wrote:
> On 8/6/2010 5:18 PM, Corinna Vinschen wrote:
> >On Aug  6 17:09, Christopher Faylor wrote:
> >>Why not present as much info as possible?  I don't know what "libkate"
> >>is but it would be nice to be able to satisfy my curiousity on that page
> >>rather than jumping to a web page and googling.
> >
> >Well, that's ok.  But I don't think it's important to learn where the
> >dependency comes from.
> 
> I disagree.  Many times (not just on cygwin, but other platforms
> too) I update a bunch of (installed) packages, or install a group of
> new ones, and the "hey, I'm going to install these dependencies now"
> page pops up.
> 
> And I think, "Geez, what the heck requires that I install the whole
> TeX distribution!! Maybe I'll rethink installing that package..."
> 
> It's a minor issue though. If you wanted to be REALLY clever, you
> could (re)structure the page as:
> 
> 	libao               version 1.0.0-1
> 	(libao's sdesc)
> 
> 	libao-devel         version 1.0.0-1
> 	(libao-devel's sdesc)
> 
> But set a tooltip [SNIP!]

Urgh.

After a bit of sleep, I see the point.  Maybe it's better to provide
as much information as possible.  What about this:


	libao	(1.0.0-1)
		Cross-Platform Audio Output Library (Transition)
		Required by: libao4, libao-devel

	libao-devel	(1.0.0-1)
		Cross-Platform Audio Output Library (Development)
		Required by: libao

	libao4	(1.0.0-1)
		Cross-Platform Audio Output Library (Runtime)
		Required by: vorbis-tools, libao, libao-devel
	[...]


Index: prereq.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/prereq.cc,v
retrieving revision 2.3
diff -u -p -r2.3 prereq.cc
--- prereq.cc	13 Dec 2009 19:23:43 -0000	2.3
+++ prereq.cc	7 Aug 2010 09:19:33 -0000
@@ -202,7 +209,10 @@ PrereqChecker::getUnmetString (std::stri
   map <packagemeta *, vector <packagemeta *>, packagemeta_ltcomp>::iterator i;
   for (i = unmet.begin(); i != unmet.end(); i++)
     {
-      s = s + "Package: " + std::string(i->first->name) + "\r\n\tRequired by: ";
+      s = s + i->first->name
+	    + "\t(" + i->first->trustp (theTrust).Canonical_version ()
+	    + ")\r\n\t" + i->first->SDesc ()
+	    + "\r\n\tRequired by: ";
       for (unsigned int j = 0; j < i->second.size(); j++)
         {
           s += i->second[j]->name;


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat