[PATCH] Stop automatic dependency selection on setup.exe chooser screen
Sat Aug 7 11:23:00 GMT 2010
On 7 August 2010 09:56, Corinna Vinschen wrote:
> On Aug 7 06:39, Andy Koppe wrote:
>> On 7 August 2010 05:29, Christopher Faylor wrote:
>> > On Fri, Aug 06, 2010 at 10:29:43PM +0100, Andy Koppe wrote:
>> >>FWIW, attached is my take on a fix for this. Getting the same
>> >>dependencies, but additional "Required bys". (Actually libcurl4 and
>> >>libssh2_1 are extra dependencies, but I assume you already have them
>> > This seems to do the same job as Corinna's and it seems to be a smaller
>> > patch. Is there a possibility of an endless loop here at all? I don't
>> > think there is but I want to be sure.
>> Attached is a simpler version, after I realised that the 'known' set
>> isn't actually needed. Added a few more comments as well.
>> I don't think an endless loop is a possibility, because only
>> dependencies that aren't in 'unmet' already are added to the todo
>> queue, so each package can make it into the queue only once.
> Your code looks much better than mine. Please go ahead and check it
> in, after testing.
Thanks, will do.
More information about the Cygwin-apps