[PATCH] inform user if any postinstall script failed to run
Fri Aug 13 10:01:00 GMT 2010
On Aug 12 15:42, Christopher Faylor wrote:
> On Thu, Aug 12, 2010 at 08:31:24PM +0100, Andy Koppe wrote:
> >On 12 August 2010 19:13, Christopher Faylor wrote:
> >Index: res.rc
> >RCS file: /cvs/cygwin-apps/setup/res.rc,v
> >retrieving revision 2.88
> >diff -u -r2.88 res.rc
> >--- res.rc 6 Aug 2010 18:56:12 -0000 2.88
> >+++ res.rc 12 Aug 2010 19:27:22 -0000
> >@@ -433,7 +433,9 @@
> > ICON IDI_CYGWIN,IDC_HEADICON,SETUP_HEADICON_X,0,21,20
> > LTEXT "Postinstall script errors",IDC_STATIC_HEADER_TITLE
> > ,7,0,258,8,NOT WS_GROUP
> >- LTEXT "The following errors occured executing
> >postinstall scripts",
> I think you still need something like the above describing what is going
> >+ LTEXT "These don't necessarily mean that affected packages will "
> >+ "fail to function properly, but if you do notice problems "
> >+ "please check /var/log/setup.log.full.",
> Could this be put on the bottom?
> Does anyone else have opinions here?
I think I have. The wording doesn't need to be overly alarming, but we
should not say "if you do notice problems ...". It's in our all
interest that problems *are* reported, even if the seem to be harmless.
But who is going to decide whether or not a failing postinstall script
is ok or not, if not we maintainers?
"The following errors occured executing postinstall scripts.
These don't necessarily mean that affected packages will fail
to function properly, but please check /var/log/setup.log.full
and report any problems."
sounds about right to me.
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
More information about the Cygwin-apps