[PATCH] Add locale/charset support to mkshortcut

Charles Wilson cygwin@cwilson.fastmail.fm
Sun Aug 15 21:43:00 GMT 2010

On 8/15/2010 5:26 PM, Andy Koppe wrote:
> On 15 August 2010 22:11, Charles Wilson wrote:
>> So, if you want to forward port your locale/charset changes and
>> cleanup-handling changes for mkshortcut (probably as two separate
>> patches) I'll try to act on them more rapidly this time. :-)
> So you'd be ok with not freeing stuff before exit()? That would make
> things quite a bit easier.

I'd rather have both "proper(?)" handling of allocated memory AND
locale/charset support -- but if it's a choice between one and the
other, I pick locale support.  In fact, I'd rather take your changes as
they are (well, without the now-gratuitous signature changes to
license(), help(), usage(), and version()) and then later worry about my
personal foibles vis handling of allocated memory -- especially as
free-before-exit is really quite pedantic.

> (Belated apologies for being too strident
> about this back then.)

Ah, it's only code.

I'm going to go ahead and roll out 1.4.4 today with the return-value
fix, and if I need to spin 1.4.6 later this week with your new stuff
that's ok.


More information about the Cygwin-apps mailing list