[PATCH] A setup.exe performance enhancement

[Jon TURNEY]

On 20/11/2010 09:43, Corinna Vinschen wrote:
> On Nov 19 14:49, Christopher Faylor wrote:
>> On Fri, Nov 19, 2010 at 04:07:23PM +0000, Jon TURNEY wrote:
>>> Change package_db collection of packages from vector to a map so we can look things up in it quickly
>>>
>>> This allows packagedb::findBinary() and packagedb::findSource() to be re-written to locate packages
>>> by name rather than searching the entire set, which makes a big difference to total execution time.
[snip]
>>
>> I was just marvelling today at the inexplicable pauses in setup.exe.  Will this
>> reduce the amount of time that setup.exe takes parsing setup.ini?

Yes, it should do.

>> Assuming that the answer is ok, I'm happy with this change but I'd like to get
>> Corinna's ok, too since it is sort of invasive.
> 
> I have no objections at all.  Go for it.

Ok, committed.

I've also uploaded a setup snapshot at [1], I would be much obliged if that
received some testing.

[1] http://cygwin.com/setup/snapshots/setup-2.738.exe