[ITP] pbzip2 (and what was the upshot on pbzip2/libbz2 incompatibility?)

[Jon TURNEY]

On 08/08/2011 17:46, Peter Li wrote:
> On 08/08/2011 01:01 AM, Corinna Vinschen wrote:
>> On Aug 7 20:31, Peter Li wrote:
>
>>> Separately, I'm curious what the upshot was on this earlier
>>> discussion of pbzip2 incompatibilities:
>>> http://cygwin.com/ml/cygwin-apps/2011-03/msg00160.html
>> I think that's fixed in setup. Jon applied a couple of patches to
>> setup on 2011-04-08 which are related, AFAICS.
> Thanks! I guess ultimately what I'm keen to know is whether this was a problem
> that is pbzip2's "fault" (and did bugs get submitted to them) or a problem
> that was purely setup.exe's "fault" or some other category...

This was definitely a bug in setup.

The bug was that a bzip2 compressed file may contain multiple
compressed streams, which should be decompressed and concatenated, but setup 
assumed that only a single stream would be present.

Files compressed using pbzip2 usually contains multiple streams (The technique 
which pbzip uses to parallelize compression should be obvious :-)), whereas 
files compressed using bzip2 seem to only contain one stream, so no problem 
was noticed until attempting to use files compressed using pbzip2.

Google seemed to indicate that this was a popular mistake to make in 
libbz2-using applications :-)