[patch/rebase] Fix build problems in imagehelper

Corinna Vinschen corinna-cygwin@cygwin.com
Tue Jun 21 08:04:00 GMT 2011

On Jun 20 20:06, Charles Wilson wrote:
> On 6/20/2011 2:52 PM, Corinna Vinschen wrote:
> > PATH_MAX = 4K should be enough.  I'm not even sure it's really
> > necessary.  DLL paths referenced in the PEB can't be longer than
> > MAX_PATH, it seems.  But a global static buffer is ok, too.
> Ack.
> I've committed all of my changes, including some cleanups like d2u
> conversion.  Everything should be copacetic now, but I'm afraid it
> probably means a lot of your patches need to be redone. :-(

No worries.  It wasn't that much, actually.  My local patches
to rebase.c and peflags.c still apply cleanly, and the patches to
imageheler were mostly mechanical.

> I've tested the build on cygwin (native) but not msys (native) or mingw
> (native).  However, it worked in the past, so...

Well, whoever is interested in having this working under msys or
mingw can send patches, right?

> Also, I'm not sure what support I built in last year for cross builds,
> but at least this version is no *worse* in that regards than prior to my
> patch.

Works fine, except for the call to ar.  I checked in a patch.

> However, I have not implemented the changes (*) you requested; if you
> want to do those, great, but otherwise I'll address them in the next day
> or two.
> (*) cygwin_conv_path vs. cygwin_create_path
>     CreateFileW vs. CreateFile

Will do.


Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

More information about the Cygwin-apps mailing list