[Mingw-w64-public] Fwd: [PATCH v1] setup: allow building with i686-w64-mingw32

[Kai Tietz]

2012/6/4 Corinna Vinschen:
> On Jun  4 09:10, Kai Tietz wrote:
>> Hello,
>>
>> here is my review about Yaakov's patch.
>>
>> The change in crt/wchar.h about __mingw_ovr macro looks wrong to me,
>> or at least inconsistent.  As stdio.h has same macro.  At least a
>> libstdc++ bootstrap test is required for this change.
>>
>> The hunks about guiddef.h are ok.
>> The hunk about ntdef.h is ok.  Also the changes for propkeydef.h header, too.
>>
>> The hunk in winnt.h:
>> @@ -88,7 +88,7 @@ extern "C" {
>>
>>  #include <basetsd.h>
>>
>> -#if defined(_X86_) || defined(__ia64__) || defined(__x86_64)
>> +#if defined(__W32API_USE_DLLIMPORT__) && (defined(_X86_) ||
>> defined(__ia64__) || defined(__x86_64))
>>  #define DECLSPEC_IMPORT __declspec(dllimport)
>>  #else
>>  #define DECLSPEC_IMPORT
>>
>> I would like to see here a different macro-name and the logic needs to
>> be inverted.  Our default scenario uses dllimport and just in cygwin's
>> setup-case we don't want it.
>> So I would like to see here instead: !defined (__NO_USE_DLLIMPORT)
>>
>> Rest of the hunks for winnt.h are ok.
>>
>> The hunks about winternl.header are ok, beside one nit.  The change in
>> FILE_RENAME_INFORMATION about RootDir from HANDLE to ULONG type I am
>
> Did I miss something?  I only see a name change:
>
>  -    BOOLEAN Replace;
>  -    HANDLE RootDir;
>  +    BOOLEAN ReplaceIfExists;
>  +    HANDLE RootDirectory;
>
> The latter names are the ones from MSDN:
> http://msdn.microsoft.com/en-us/library/windows/hardware/ff540344%28v=vs.85%29.aspx
>
>
> Corinna

Ups, I mis-read that.  Yes, indeed. change about winternl.h header are ok.

Sorry,
Kai