[PATCH setup] (Usability improvement) Implement half-second wait for user to finish typing before searching packages

[Corinna Vinschen]

On Aug  1 23:17, Ronald Ramos wrote:
> commit 357c1e7576586349efb8514dc9d8d03950e225ee
> Author: Ronald Ramos <ronjoe223@gmail.com>
> Date:   Mon Aug 1 23:05:44 2016 -0400
> 
>     * proppage.h (PropertyPage)
>         New member OnTimerMessage (delegates similarly to OnMouseWheel)
> 
>     * proppage.cc
>         (DialogProc) Added handling of WM_TIMER
> 
>     * choose.h (ChooserPage)
>         (OnTimerMessage) New function prototype
>         (timer_id) New member variable
>         Added DEFINE-ed default values for timer_id and search timer delay
>         Reorganized private members for consistency
> 
>     * choose.cc
>         (constructor) Initialize timer_id
>         (OnMessageCmd) Replaced search-refresh with a SetTimer
>         (OnSearchTimer) New; contains search-refresh removed from
> OnMessageCmd

Neat!  Applied.  Personally I would rather see a shorter timeout like,
say, 300ms, but I guess we shouldn't take for granted that everybody is
typing fast.  Even with 500ms timeout it's now much more convenient than
the old "search after each keypress" method.

However.  Your MUA seems to scramble patches as part of the mail text,
e.g., it adds line breaks which break `patch' or `git am'.

It would be nice if you could fix this.  Alternatively, just attach the
output from `git format-patch' as mail attachment.  That usually works
nicely.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Maintainer                 cygwin AT cygwin DOT com
Red Hat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20160802/1641e4b7/attachment.sig>