[PATCH] Do not clear the prev, curr and exp fields of packagemeta. Never.
Houder
houder@xs4all.nl
Wed May 4 12:39:00 GMT 2016
Hi,
I have prepared a patch to setup.exe, but I do not know how to submit
it. For
this reason. I have attached the result of 'git format-patch' to this
message.
Please, submit this patch.
This patch rectifies
- packagemeta::ScanDownloadedFiles (package_meta.cc), and
- packagemeta::trustp (package_meta.h)
Clarification:
Class packagemeta has "fields" prev, curr, exp and installed, which in
fact
represent the info from setup.ini/installed.db, and should never be
cleared
therefore. _Currently_ these fields are cleared in ScanDownloadedFiles()
in
order to notify that the tarball for the associated field is not
available.
This is a mistake, as it destroys relevant info (e.g. the version number
of
a version).
To ascertain whether or not the associated tarball is available, one
should
invoke <field>.accesible().
Note: yes, "field" is type packageversion.
Regards,
henri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Do-not-clear-the-prev-curr-and-exp-fields-of-package.patch
Type: text/x-diff
Size: 4194 bytes
Desc: not available
URL: <http://cygwin.com/pipermail/cygwin-apps/attachments/20160504/1f277844/attachment.bin>
More information about the Cygwin-apps
mailing list