[PATCH setup 11/11] Use wininet for fetching URLs in direct (non-proxy) case (DO NOT APPLY)

Jon Turney jon.turney@dronecode.org.uk
Tue May 16 14:00:00 GMT 2017


On 04/05/2017 11:11, Jon Turney wrote:
> On 03/05/2017 18:08, Ã
ke Rehnman wrote:
>> On 2017-05-03 18:37, Jon Turney wrote:
>>>
>>> * Allow wininet to handle file:// URLs
>>>
>>> I'm a little bit concerned that there may be current uses which rely
>>> on the incorrect parsing we do of file:// URLs to work.
>>>
>>> Otoh, this should fix the file:// URL format we currently mishandle,
>>> so is probably worth doing.
>> I don't know how that could have ever worked... (or does it?)
>
> Not really, see the other branch of this thread.

So, I taking another look at this:

I am a bit confused about the behaviour I'm seeing, though.

I'm expecting "file:///c:/path" and "file://host/path" to work, but they 
don't seem to.

However, "file://c:/path" now works, which is good, and 
"file:////host/path" continues to work

The documentation for InternetOpenUrl() says "Only URLs beginning with 
ftp:, http:, or https: are supported" so I'm wondering if this is really 
something we should be expecting to work...

Also, is there a reason for the hunk in nio-file.cc removing the 
reporting of a problem opening the file?




More information about the Cygwin-apps mailing list