[PATCH setup 0/2] Improve behavior after download error

[Brian Inglis]

On 2017-11-07 11:56, Jon Turney wrote:
> On 07/11/2017 04:28, Brian Inglis wrote:
>> On 2017-11-06 14:49, Ken Brown wrote:
>>> This is a followup to
>>> https://sourceware.org/ml/cygwin-apps/2017-11/msg00003.html.  The
>>> focus of that thread was a crash that occurs on the topic/libsolv
>>> branch.  Here I'm more interested in a UI issue.  Namely, I don't
>>> think it's reasonable that setup goes back to the site page if the
>>> user clicks Yes in response to "Download Incomplete. Try again?".
>>> This is not what the message says will happen, and I'm not convinced
>>> that it even works right if the user changes mirrors after being sent
>>> to the site page.
>>
>> Would it make more sense to drop to the package chooser page, after issuing the
>> error message and advising the user to: select Back to go to the package chooser
>> page, select Next to retry the downloads, or select Cancel to exit?
> 
> Do we actually report the package name for the failed download so that the user
> could make an informed change in the package chooser?

Don't remember ever having a package download failure, normally mirror download
problems are at the setup.ini... stage, possibly accessing during an rsync, then
the packages download okay.

> In any case, this is an incremental improvement, especially over the utterly mad
> thing we are currently doing in unattended mode.

I like to retry the download on the current mirror, then either pick another
mirror, or quit and wait awhile.
In (semi-)unattended mode, you should either decide to quit as if unattended, or
possibly go into full interactive mode and allow Back, Next, Cancel without limits?

-- 
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada