[PATCH setup 0/5] Improve behavior after download error, v2

Ken Brown kbrown@cornell.edu
Fri Nov 10 14:43:00 GMT 2017

Currently setup goes back to the mirror selection page after a
download error if the user answers "Yes" to "Download incomplete.  Try
again?".  The same happens in unattended mode until the retries have
been exhausted.

And if the user answers "No", then installation continues, even though
this can damage the user's installation.  For example, if a package is
selected for reinstall but cannot be downloaded, it will be

This series of patches changes the behavior as follows:

 - In unattended mode, simply retry the download.

 - In interactive mode, pop up a dialog showing which packages had
   download errors and giving the user the following options:
    - Retry (retries download)
    - Back (return to the package selection page)
    - Continue, with a warning
    - Cancel (exit)

Ken Brown (5):
  Just retry download after error in unattended mode
  Fix off-by-one error in download retry report
  Remove "Try again?" from exit message.
  Query user after download error in interactive mode
  Limit the number of packages shown in the IDD_DOWNLOAD_ERROR listbox

 download.cc | 99 ++++++++++++++++++++++++++++++++++++++++++++++++++++---------
 res.rc      | 23 ++++++++++++++
 resource.h  |  3 ++
 3 files changed, 111 insertions(+), 14 deletions(-)


More information about the Cygwin-apps mailing list