[PATCH setup] Don't write garbage into the "extrakeys" user setting
Jon Turney
jon.turney@dronecode.org.uk
Mon Nov 27 22:26:00 GMT 2017
On 27/11/2017 21:35, Ken Brown wrote:
> The ExtraKeysSetting destructor called UserSettings::set() on a string
> that was terminated by LF instead of NUL. This led to garbage at the
What...?!?
> /*
> * It stores them all in a contiguous memory buffer. Each is one line of
> * ASCII text terminated by LF. THERE IS NO NUL-TERMINATION HERE, TAKE CARE!
> */
Awesome... :)
> end of the "extrakeys" setting that was written into setup.rc. Fix
> this by replacing the final LF by NUL before calling set().
Thanks for tracking this down. Please apply.
More information about the Cygwin-apps
mailing list