[PATCH] Revert "Don't override a Keep selection"

Jon Turney jon.turney@dronecode.org.uk
Tue Oct 17 18:43:00 GMT 2017

On 16/10/2017 20:13, Ken Brown wrote:
> This reverts (the rest of) commit b43b697.  Part of that commit was
> already reverted in commit ff0bb3d.  The rest is not needed either
> since we no longer send the upgrade flag to the solver after the user
> has made their selections.
> ---
>   libsolv.cc     | 14 +++-----------
>   libsolv.h      |  1 -
>   package_meta.h |  2 --
>   3 files changed, 3 insertions(+), 14 deletions(-)

Hmm... not sure about this.

Say the initial upgrade solution had something like: package A 1.0 -> 
1.1, and A 1.1 has a dependency on package B 2.0, where currently B 1.0 
is installed (so B 1.0 -> 2.0)

If the user then changes B to 'keep' (at 1.0), we should report a conflict?

Does keeping this cause a problem?

I guess we are generating a huge number of these tasks into the solver 
because "Keep" is kind of overloaded between "Don't care (but it just 
happens that I know that there's nothing to do)" and "Lock"?

More information about the Cygwin-apps mailing list