[PATCH] Revert "Don't override a Keep selection"
Thu Oct 19 03:01:00 GMT 2017
On 10/17/2017 3:31 PM, Ken Brown wrote:
> On 10/17/2017 2:43 PM, Jon Turney wrote:
>> On 16/10/2017 20:13, Ken Brown wrote:
>>> This reverts (the rest of) commit b43b697.Â Part of that commit was
>>> already reverted in commit ff0bb3d.Â The rest is not needed either
>>> since we no longer send the upgrade flag to the solver after the user
>>> has made their selections.
>>> Â libsolv.ccÂ Â Â Â | 14 +++-----------
>>> Â libsolv.hÂ Â Â Â Â |Â 1 -
>>> Â package_meta.h |Â 2 --
>>> Â 3 files changed, 3 insertions(+), 14 deletions(-)
>> Hmm... not sure about this.
>> Say the initial upgrade solution had something like: package A 1.0 ->
>> 1.1, and A 1.1 has a dependency on package B 2.0, where currently B
>> 1.0 is installed (so B 1.0 -> 2.0)
>> If the user then changes B to 'keep' (at 1.0), we should report a
> Good point.Â I wasn't thinking about dependencies with version relations.
I just tested this scenario, and it turns out that putting a lock on B
1.0 overrides the dependency of A 1.1 on B 2.0. There's no problem
reported. On the other hand, if there's no lock, then the dependency
overrides the Keep choice, again with no problem reported.
Back to the drawing board.
More information about the Cygwin-apps