[PATCH setup] Make sure that fatal error messages are visible

Jon Turney jon.turney@dronecode.org.uk
Fri Jan 5 13:54:00 GMT 2018

On 28/12/2017 01:38, Ken Brown wrote:
> On 12/21/2017 5:55 PM, Ken Brown wrote:
>> On 12/20/2017 12:09 PM, Ken Brown wrote:
>>> On 12/20/2017 11:19 AM, Jon Turney wrote:
>>>> On 19/12/2017 00:53, Ken Brown wrote:
>>>>> The message box produced by TOPLEVEL_CATCH could be hidden by whatever
>>>>> window was previously being displayed, so that setup appeared to hang.
>>>>> Fix this by giving fatal error message boxes type MB_SETFOREGROUND.
>>>> This is good as far as it goes, but is kind of working around the 
>>>> fact that fatal() is being called with an NULL owner HWND.
> I think I have a better solution, which simply avoids calling fatal() 
> with a NULL owner HWND (with one exception).
> New patch attached.

Great. Please apply.

More information about the Cygwin-apps mailing list