[PATCH setup] Throw exceptions instead of exiting with error codes
Mon Jan 8 13:54:00 GMT 2018
On 20/12/2017 16:25, Ken Brown wrote:
> On 12/20/2017 11:06 AM, Jon Turney wrote:
>> On 19/12/2017 17:20, Ken Brown wrote:
>>> Â Exception.h |Â 1 +
>>> Â PickView.cc | 11 +++++++----
>>> Â choose.ccÂ Â |Â 7 +++++--
>>> Â 3 files changed, 13 insertions(+), 6 deletions(-)
>> Yeah, silently dying seems like a bad idea.
>> Hmmm... does this not need a corresponding use of TOPLEVEL_CATCH to
>> transform that exception into a fatal() ?
> It's already caught by a TOPLEVEL_CATCH.
>> In any case, some commentary in the commit about how these exceptions
>> are expected to be handled would good.
> Revised patch attached.
Looks good, please apply.
More information about the Cygwin-apps