[PATCH setup libsolv, v2] Let the user review added dependencies

[cyg Simple]

On 1/22/2018 8:07 PM, Brian Inglis wrote:
> On 2018-01-22 15:40, Ken Brown wrote:
>> On 1/22/2018 4:51 PM, Brian Inglis wrote:
>>> On 2018-01-22 10:37, Ken Brown wrote:
>>>> If the solver found no problems but added packages to resolve
>>>> dependencies, ask the user whether they want to review the added
>>>> packages before proceeding.
>>>>
>>>> If they answer Yes, go back to the chooser with the 'Pending' view
>>>> selected.  The implementation adds several new members to the
>>>> PrereqChecker class so that the latter can communicate with the
>>>> chooser page.
>>>
>>> Would it not be better, quicker, and easier, and to just show the updated
>>> Pending view directly and unconditionally, without another popup dialogue box?
>>> I think that's what most of us would expect from a UI display: just update the
>>> displayed packages, if not being asked for confirmation that we really want to
>>> do something possibly detrimental.
>>
>> Yes, I think you're right, in principle.  But I'm not sure exactly what the UI
>> should do.  If we simply update the displayed packages when the user selects
>> 'Next', won't the user wonder what's going on?  Can you suggest a way to make it
>> clear that we've updated the display to reflect added dependencies and that
>> we're waiting for final confirmation?
> 
> I see what you mean: we don't have a status line or any way to highlight added
> dependencies which we could use to convey that, so unless the addition of
> dependencies to the Pending view is visually very obvious, we need to use a
> dialogue box to pass on the message, before proceeding from the Pending view.
> 

How about changing the background color when the pending view list
changes?  The typical case for added dependencies is to just accept
them; especially if the primary package is really wanted.  Maybe rotate
between three or four colors to indicate new data in the list for each
selection but just two is good as well.

Also maybe changing the text on the Next button to indicate the total
number of packages pending action.  It would be another visual clue.

-- 
cyg Simple