setup: problems with local install

[Ken Brown]

On 3/5/2018 1:34 PM, Ken Brown wrote:
> This is a followup to the thread started here:
> 
>  Â  https://cygwin.com/ml/cygwin/2018-03/msg00027.html
> 
> There are two problems with installing from a local directory.
> 
> 1. In the Category view, "No packages found" is displayed where it 
> should say "All" in the first line of the list.  This is probably just a 
> cosmetic issue, and I haven't tried to track it down yet.

This actually happens in all setup runs, not just local installs.  It 
looks like it was caused by the rearranging that was done in the 
following commit:

commit 0c539f7f7d86fb100f260f21367682fa2c0bb529
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Sat Nov 4 18:01:49 2017 +0000

     Correctly order preparing packagedb for chooser

I think the problem might be that createListview() is now called too 
early in ChooserPage::OnInit().  But it's not immediately obvious to me 
how to fix this without breaking something else.

Ken