[PATCH setup 00/11] Improve handling of specifying an obsolete package to be installed on the command line

[Ken Brown]

On 8/1/2019 12:05 PM, Jon Turney wrote:
> e.g. setup -q -g -P python3-lxml (which used to do something useful)
> currently gets you an (empty) python3-lxml package, which will be replaced
> by python36-lxml (which obsoletes it) on the next setup run. After this
> change, python36-lxml is installed instead.
> 
> See also the dicusssion at
> https://cygwin.com/ml/cygwin-apps/2017-10/msg00092.html et seq. (where I
> come to the (incorrect) conclusion that since we don't need this for
> interactive use, it's not needed)
> 
> Jon Turney (11):
>    Remove 'Bin?' column
>    Remove unused packagemeta::key
>    Make packagemeta::message private
>    Rename 'Default' packagemeta action to 'NoChange' for clarity
>    Store the requested action in packagemeta::set_action()
>    Use packagemeta::set_action() to update action
>    Use stored action in setting up solver
>    Allow better handling of an obsolete package specified on command line
>    Use stored action in packagemeta::list_actions()
>    Use stored action in packagemeta::action_caption()
>    Ensure we only set user_picked when appropriate
> 
>   PickCategoryLine.cc |  2 +-
>   PickPackageLine.cc  | 32 +---------------
>   PickView.cc         |  3 +-
>   PickView.h          | 12 +++---
>   choose.cc           |  9 ++---
>   libsolv.cc          | 69 ++++++++++++++++++++-------------
>   libsolv.h           |  1 +
>   package_db.cc       |  4 +-
>   package_meta.cc     | 93 ++++++++++++++++++++++-----------------------
>   package_meta.h      | 16 ++++----
>   10 files changed, 113 insertions(+), 128 deletions(-)

Jon,

Since you don't seem to have gotten any feedback on this patch series, I just 
want to let you know that I've been running setup.exe with these patches for a 
couple months, and I haven't seen any regressions.  (But I haven't done any 
systematic testing or review.)

Ken