cygport: Request a new feature in order to set owner/group names in packaged tarballs.

Lemures Lemniscati lemures.lemniscati@gmail.com
Mon Aug 10 21:45:53 GMT 2020


On Mon, 10 Aug 2020 21:51:35 +0200, Achim Gratz
> Lemures Lemniscati via Cygwin-apps writes:
> > [1]: https://github.com/cygwin-lem/cygport/commit/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b
> 
> You set the variable CYGPORT_TAR_EXT in pkg_pkg.cygpart, then use it in
> pkg_upload-cygport.  Have you verified tha the latter will have that
> definition included regardless of the code path taken?
> 

Thank you for reviewing, Achim.


Both of pkg_pkg.cygpart and pkg_upload.cygpart are called from cygport
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L325-L331

before the functions are called.
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L561-L565



But, probably, configuration like this should go to a more suitable
place, as written in comments (in order to avoid concerning which you
have pointed out)
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/lib/pkg_pkg.cygpart#L23-L24

For example, it might be placed in this part
https://github.com/cygwin-lem/cygport/blob/7ae236b524fa5f5b27f9773cdf21ee4f6624a53b/bin/cygport.in#L249-L274


Regards,
Lem


More information about the Cygwin-apps mailing list