[ITA] fortune-mod - please review

Jon Turney jon.turney@dronecode.org.uk
Sun Apr 11 15:16:15 GMT 2021

On 09/04/2021 17:49, Brian Inglis wrote:
> Please review:
> - build now uses cmake
> - build requires unpackaged cpan module, installing with cpan in .cygport
> - x86 will not build with ninja, only if deinstalled
> - x86 applies but also regenerates source patches

Can you be a bit more explicit what the issues are on x86?

> See Google Drive for review files:
> https://drive.google.com/drive/folders/15500wdTKygcwVNB7-0XN9P6kd9pvByxJ

For future reference, giving a link to the cygport, rather than having 
to dig it out of the source package would ease review.

> DEPEND="cmake ninja perl"

build requires also seem to include Perl-Path-Tiny.

> cpan App::XML::DocBook::Builder

This is less than ideal, as this means this gets executed as a side 
effect any time the cygport is sourced (e.g. if you run 'cygport 
fortune-mod.cygport info').

If you really can't get this packaged, maybe it should be in the 
src_compile instead?

Apart from that, looks good.

More information about the Cygwin-apps mailing list