[ITA] giflib

Jon Turney jon.turney@dronecode.org.uk
Sun May 29 16:12:03 GMT 2022


On 29/05/2022 12:45, Lemures Lemniscati wrote:
> Hi!
> 
> 
> ITA for giflib, which has been maintained by Yaakov [1].

Thanks. I added this to your authorized packages.

Small comments on the .cygport:

> # Patch files whose names are in a default style of 'git format-patch'
> PATCH_URI+=$(\
>   find -maxdepth 1 -type f -name '[0-9][0-9][0-9][0-9]-*.patch' \
>   | sort \
> )

Hmm... there's probably a case to be made that this is something that 
cygport should be doing automatically.

It would certainly help with noticing when patches are removed from 
PATCH_URI but not from the source package repo...

> 
> BUILD_REQUIRES="\
>   cmake\
>   ninja\
> "

I don't think these need to be listed because they are implied by the 
respective inherits.

Certainly, if things are working as intended, scallywag can infer that.


More information about the Cygwin-apps mailing list