Issue with another downstream over DESTDIR builds
Thu Sep 29 19:15:48 GMT 2022
Hi folks, [Please Reply All to CC me as ISP blocking Cygwin lists]
I previously submitted a patch upstream to add DESTDIR when creating
package symlinks so cygport builds work without patches.
Now another downstream is disputing that, requesting the patch be
reverted, saying that symlink targets are contents and should always be
from the non-DESTDIR native source as per GNU "rules" in the autobook.
We agreed to request other more experienced opinions on this issue from
our support groups and report back.
I am asking the perhaps more experienced professional maintainers to
provide their considered opinion on this issue, demonstrated by the
reversion patch below.
> The link's target must not include $(DESTDIR), otherwise this ends up
> included in the shipped link. Linking the theoretical target gives the
> correct result.
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -115,7 +115,7 @@
> $(INSTALL_DATA) $(srcdir)/definitions.units $(DESTDIR)@UDAT@definitions.units
> -rm -f $(DESTDIR)@UDAT@currency.units
> $(INSTALL_DATA) $(srcdir)/currency.units $(DESTDIR)@CDAT@currency.units
> - if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf $(DESTDIR)@CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi
> + if [ $(DESTDIR)@CDAT@ != $(DESTDIR)@UDAT@ ];then ln -sf @CDAT@currency.units $(DESTDIR)@UDAT@currency.units;fi
> $(INSTALL_DATA) $(srcdir)/locale_map.txt $(DESTDIR)@UDAT@locale_map.txt
> if test $(HAVE_PYTHON) = yes; then \
> $(INSTALL_PROGRAM) units_cur_inst $(DESTDIR)$(bindir)/`echo units_cur|sed '$(transform)'`;fi
Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
This email may be disturbing to some readers as it contains
too much technical detail. Reader discretion is advised.
[Data in binary units and prefixes, physical quantities in SI.]
More information about the Cygwin-apps