[newlib-cygwin] Add comment to point out missing access right per documentation

Corinna Vinschen corinna@sourceware.org
Mon Jun 27 16:01:00 GMT 2016


commit 532ecdd36f37e4c5985b8a7c992324e5df48f7a1
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Jun 27 18:00:01 2016 +0200

    Add comment to point out missing access right per documentation
    In get_mem_values we open the process without PROCESS_VM_READ access
    and are *still* able to request working set information, despite
    MSDN claiming we need it for this purpose.  Instead of adding this
    access right, just add an comment to point this out for now.
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

 winsup/cygwin/fhandler_process.cc | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/winsup/cygwin/fhandler_process.cc b/winsup/cygwin/fhandler_process.cc
index 9730fa7..216f095 100644
--- a/winsup/cygwin/fhandler_process.cc
+++ b/winsup/cygwin/fhandler_process.cc
@@ -1436,6 +1436,10 @@ get_mem_values (DWORD dwProcessId, unsigned long *vmsize, unsigned long *vmrss,
   SIZE_T n = 0x4000, length;
+  /* This appears to work despite MSDN claiming that QueryWorkingSSet requires
+     PROCESS_QUERY_INFORMATION *and* PROCESS_VM_READ.  Since we're trying to do
+     everything with least perms, we stick to PROCESS_QUERY_INFORMATION only
+     unless this changes in Windows for some reason. */
   hProcess = OpenProcess (PROCESS_QUERY_INFORMATION, FALSE, dwProcessId);
   if (hProcess == NULL)

More information about the Cygwin-cvs mailing list