[newlib-cygwin] Cygwin: fix permissions of winpid symlinks

Corinna Vinschen corinna@sourceware.org
Mon Mar 11 20:40:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=d9f934c9e9ec5588e6c616e9c63dd348995dafa8

commit d9f934c9e9ec5588e6c616e9c63dd348995dafa8
Author: Corinna Vinschen <corinna@vinschen.de>
Date:   Mon Mar 11 21:40:04 2019 +0100

    Cygwin: fix permissions of winpid symlinks
    
    The winpid symlinks got created with no query permissions, so
    only admins could see all Cygwin processes.  Create symlinks
    so everyone has query permissions instead.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/pinfo.cc      |  3 ++-
 winsup/cygwin/release/3.0.4 | 13 +++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc
index 064299e..453861c 100644
--- a/winsup/cygwin/pinfo.cc
+++ b/winsup/cygwin/pinfo.cc
@@ -325,7 +325,8 @@ pinfo::create_winpid_symlink ()
   __small_swprintf (pid_name, L"%u", procinfo->pid);
   RtlInitUnicodeString (&pid_str, pid_name);
   InitializeObjectAttributes (&attr, &sym_str, OBJ_CASE_INSENSITIVE,
-			      get_shared_parent_dir (), NULL);
+			      get_shared_parent_dir (),
+			      everyone_sd (SYMBOLIC_LINK_QUERY));
   NtCreateSymbolicLinkObject (&winpid_hdl, SYMBOLIC_LINK_ALL_ACCESS,
 			      &attr, &pid_str);
 }
diff --git a/winsup/cygwin/release/3.0.4 b/winsup/cygwin/release/3.0.4
new file mode 100644
index 0000000..c545f3e
--- /dev/null
+++ b/winsup/cygwin/release/3.0.4
@@ -0,0 +1,13 @@
+What's new:
+-----------
+
+
+What changed:
+-------------
+
+
+Bug Fixes
+---------
+
+- Fix access to process list
+  Addresses: https://cygwin.com/ml/cygwin/2019-03/msg00253.html



More information about the Cygwin-cvs mailing list