[newlib-cygwin] Cygwin: pty: Fix PTY so that cygwin setup shows help with -h option.

Ken Brown kbrown@sourceware.org
Thu Sep 26 12:49:00 GMT 2019


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=e1a0775dc0545b5f9c81b09a327fc110c538b7b4

commit e1a0775dc0545b5f9c81b09a327fc110c538b7b4
Author: Takashi Yano <takashi.yano@nifty.ne.jp>
Date:   Thu Sep 26 19:52:46 2019 +0900

    Cygwin: pty: Fix PTY so that cygwin setup shows help with -h option.
    
    - After commit 169d65a5774acc76ce3f3feeedcbae7405aa9b57, cygwin
      setup fails to show help message when -h option is specified, as
      reported in https://cygwin.com/ml/cygwin/2019-09/msg00248.html.
      This patch fixes the problem.

Diff:
---
 winsup/cygwin/spawn.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc
index 4d8bcc9..f8090a6 100644
--- a/winsup/cygwin/spawn.cc
+++ b/winsup/cygwin/spawn.cc
@@ -790,8 +790,6 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
 	  NtClose (old_winpid_hdl);
 	  real_path.get_wide_win32_path (myself->progname); // FIXME: race?
 	  sigproc_printf ("new process name %W", myself->progname);
-	  if (!iscygwin ())
-	    close_all_files ();
 	}
       else
 	{
@@ -890,6 +888,8 @@ child_info_spawn::worker (const char *prog_arg, const char *const *argv,
 		wait_for_myself ();
 	    }
 	  myself.exit (EXITCODE_NOSET);
+	  if (!iscygwin ())
+	    close_all_files ();
 	  break;
 	case _P_WAIT:
 	case _P_SYSTEM:



More information about the Cygwin-cvs mailing list