[newlib-cygwin] Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.

Corinna Vinschen corinna@sourceware.org
Mon Mar 8 14:02:54 GMT 2021


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=850b5a9aae49a9a0fa21d3ace385e8d6b03ae285

commit 850b5a9aae49a9a0fa21d3ace385e8d6b03ae285
Author: Takashi Yano via Cygwin-patches <cygwin-patches@cygwin.com>
Date:   Mon Mar 8 22:14:58 2021 +0900

    Cygwin: pty: Attach to stub process when non-cygwin app inherits pcon.
    
    - If two non-cygwin apps are started simultaneously, attaching to
      pseudo console sometimes fails. This is because the second app
      trys to attach to the process not started yet. This patch avoids
      the issue by attaching to the stub process rather than the other
      non-cygwin app.

Diff:
---
 winsup/cygwin/fhandler_tty.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc
index 4358bceec..3bfc8c0c8 100644
--- a/winsup/cygwin/fhandler_tty.cc
+++ b/winsup/cygwin/fhandler_tty.cc
@@ -3104,7 +3104,7 @@ fhandler_pty_slave::setup_pseudoconsole (bool nopcon)
 		       0, TRUE, DUPLICATE_SAME_ACCESS);
       CloseHandle (pcon_owner);
       FreeConsole ();
-      AttachConsole (p->dwProcessId);
+      AttachConsole (p->exec_dwProcessId);
       goto skip_create;
     }


More information about the Cygwin-cvs mailing list