[newlib-cygwin] Cygwin: testsuite: Also check direct call in systemcall

Jon Turney jturney@sourceware.org
Fri Jul 14 15:28:18 GMT 2023


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=79a9288434aaa15407727474f26504214b027306

commit 79a9288434aaa15407727474f26504214b027306
Author: Jon Turney <jon.turney@dronecode.org.uk>
Date:   Sun Jul 9 12:12:23 2023 +0100

    Cygwin: testsuite: Also check direct call in systemcall
    
    Check direct call to system(), as well as one in a subprocess.
    
    (This is a lot easier to debug when it's completely broken by the
    environment the test is running in)
    
    Signed-off-by: Jon Turney <jon.turney@dronecode.org.uk>

Diff:
---
 winsup/testsuite/winsup.api/systemcall.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/winsup/testsuite/winsup.api/systemcall.c b/winsup/testsuite/winsup.api/systemcall.c
index d10c9825c..74bd6f870 100644
--- a/winsup/testsuite/winsup.api/systemcall.c
+++ b/winsup/testsuite/winsup.api/systemcall.c
@@ -26,6 +26,14 @@ main (int argc, char **argv)
       fprintf (stderr, "couldn't redirect stdout to /dev/null, fd %d - %s\n", fd, strerror (errno));
       exit (1);
     }
+
+  n = system ("ls");
+  if (n != 0)
+    {
+      fprintf (stderr, "system() (in parent) call returned %x\n", n);
+      exit (1);
+    }
+
   if (pipe (fds))
     {
       fprintf (stderr, "pipe call failed - %s\n", strerror (errno));
@@ -61,7 +69,7 @@ main (int argc, char **argv)
     }
   if (n != 0)
     {
-      fprintf (stderr, "system() call returned %x\n", n);
+      fprintf (stderr, "system() (in child) call returned %x\n", n);
       exit (1);
     }
   exit (0);


More information about the Cygwin-cvs mailing list