[newlib-cygwin/main] Cygwin: pinfo: use stpcpy where appropriate

Corinna Vinschen corinna@sourceware.org
Thu Feb 1 11:39:39 GMT 2024


https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=b1d64ac265f01f2efcff495b963982ca741269d9

commit b1d64ac265f01f2efcff495b963982ca741269d9
Author:     Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Tue Jan 30 20:42:37 2024 +0100
Commit:     Corinna Vinschen <corinna@vinschen.de>
CommitDate: Wed Jan 31 20:11:58 2024 +0100

    Cygwin: pinfo: use stpcpy where appropriate
    
    ...rather than strcpy/strchr.
    
    Signed-off-by: Corinna Vinschen <corinna@vinschen.de>

Diff:
---
 winsup/cygwin/pinfo.cc | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/winsup/cygwin/pinfo.cc b/winsup/cygwin/pinfo.cc
index bfd338e5b85a..f6a9712a4164 100644
--- a/winsup/cygwin/pinfo.cc
+++ b/winsup/cygwin/pinfo.cc
@@ -515,7 +515,7 @@ const char *
 _pinfo::_ctty (char *buf)
 {
   if (!CTTY_IS_VALID (ctty))
-    strcpy (buf, "no ctty");
+    stpcpy (buf, "no ctty");
   else
     {
       device d;
@@ -1170,10 +1170,7 @@ _pinfo::cmdline (size_t& n)
       char *p;
       p = s = (char *) cmalloc_abort (HEAP_COMMUNE, n);
       for (char **a = __argv; *a; a++)
-	{
-	  strcpy (p, *a);
-	  p = strchr (p, '\0') + 1;
-	}
+	p = stpcpy (p, *a) + 1;
     }
   return s;
 }
@@ -1231,10 +1228,7 @@ _pinfo::environ (size_t& n)
   char *p, *s;
   p = s = (char *) cmalloc_abort (HEAP_COMMUNE, n);
   for (char **e = env; *e; e++)
-    {
-      strcpy (p, *e);
-      p = strchr (p, '\0') + 1;
-    }
+    p = stpcpy (p, *e) + 1;
   return s;
 }


More information about the Cygwin-cvs mailing list