[newlib-cygwin/main] Cygwin: pipe: do short writes only once in nonblocking case too
Corinna Vinschen
corinna@sourceware.org
Mon Aug 19 09:51:32 GMT 2024
https://sourceware.org/git/gitweb.cgi?p=newlib-cygwin.git;h=686e46ce714803f47d3183c954ceaf51976157cc
commit 686e46ce714803f47d3183c954ceaf51976157cc
Author: Corinna Vinschen <corinna@vinschen.de>
AuthorDate: Mon Aug 19 11:51:14 2024 +0200
Commit: Corinna Vinschen <corinna@vinschen.de>
CommitDate: Mon Aug 19 11:51:14 2024 +0200
Cygwin: pipe: do short writes only once in nonblocking case too
If a nonblocking write requires short writes, just try it once
as in the blocking case. After all, we are nonblocking, so
don't loop unnecessarily.
Fixes: 170e6badb621 ("Cygwin: pipe: improve writing when pipe buffer is almost full")
Signed-off-by: Corinna Vinschen <corinna@vinschen.de>
Diff:
---
winsup/cygwin/fhandler/pipe.cc | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/winsup/cygwin/fhandler/pipe.cc b/winsup/cygwin/fhandler/pipe.cc
index 34b295c4de0a..852076ccc4e8 100644
--- a/winsup/cygwin/fhandler/pipe.cc
+++ b/winsup/cygwin/fhandler/pipe.cc
@@ -574,8 +574,7 @@ fhandler_pipe_fifo::raw_write (const void *ptr, size_t len)
len1 = avail & ~(PIPE_BUF - 1);
else
len1 = 1 << (31 - __builtin_clzl (avail));
- if (!is_nonblocking ())
- short_write_once = true;
+ short_write_once = true;
}
if (isclosed ()) /* A signal handler might have closed the fd. */
{
More information about the Cygwin-cvs
mailing list